Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cakeday? #682

Closed
poperigby opened this issue Apr 30, 2020 · 15 comments
Closed

Cakeday? #682

poperigby opened this issue Apr 30, 2020 · 15 comments
Labels
extra: good first issue Good for newcomers

Comments

@poperigby
Copy link

This is a nice little feature that I like on Reddit. Would it work okay through federation?

@dessalines
Copy link
Member

Ya it could. We set up a proper user creation date for federated users I'm pretty sure.

@Nutomic
Copy link
Member

Nutomic commented Apr 30, 2020

We are federating the user creation time already, so this only needs a check in the frontend. Should be pretty easy to do.

@Nutomic Nutomic added the extra: good first issue Good for newcomers label Apr 30, 2020
@niniack
Copy link
Contributor

niniack commented Apr 30, 2020

I love this idea!

Should we call it cakeday though? Would we be better off recognizing it differently?

@sylviaji
Copy link
Contributor

Hi, we’d like to work on this issue as a group (@niniack & @Charleshthomasiii )! I've got a few questions:

  1. Should the cake day be displayed on the user profile and replace “Joined xxxx ago”?
    lemmy_cakeday
  2. Should there be an option for the user to hide the cake day in settings (I know you can’t do that on reddit)?

Thanks!!

@dessalines
Copy link
Member

Don't worry about hiding the cakeday, that's not necessary.

user-listing.tsx is the place where you'd add an icon, you can look in the other .tsx files for examples of icons and in the symbols.tsx to add them.

@niniack
Copy link
Contributor

niniack commented May 2, 2020

Throwing this in for an icon candidate, very open to suggestions!

lemmy_cakeday

@poperigby
Copy link
Author

poperigby commented May 2, 2020 via email

@sylviaji
Copy link
Contributor

sylviaji commented May 2, 2020

Some more cakes!
cakes_icons

@poperigby
Copy link
Author

My favorites are either bottom left or top right. Leaning more towards top right.

@poperigby
Copy link
Author

Throwing this in for an icon candidate, very open to suggestions!

lemmy_cakeday

It looks a little too "pie-like" with the crust. Maybe make it more of an outline to look like it's frosting.

@niniack
Copy link
Contributor

niniack commented May 3, 2020

@poperigby its a cheeky cheesecake hahah :)

@sylviaji
Copy link
Contributor

sylviaji commented May 8, 2020

Don't worry about hiding the cakeday, that's not necessary.

user-listing.tsx is the place where you'd add an icon, you can look in the other .tsx files for examples of icons and in the symbols.tsx to add them.

I’m wondering what is the recommended way to get the user creation date from user-listing.tsx. Should I pass the user creation date as a prop to the UserListing component wherever it’s used, or is it possible to get the creation date by username? Thanks!

@dessalines
Copy link
Member

It comes from the input props, just trace down the references for UserListing.

@Filip785
Copy link
Contributor

Filip785 commented Jul 7, 2020

Hi @dessalines, I see that this issue has no PR yet, can I submit one?

@dessalines
Copy link
Member

Sure, go ahead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extra: good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants