-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move resolving of activitypub objects to separate api endpoint #1666
Conversation
.href | ||
.to_owned() | ||
.ok_or_else(|| anyhow!("No href found.").into()) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I'm just moving things to the library whenever that makes sense. Later I need to figure out how to remove the dependencies on lemmy crates (eg passing local domain to the library somehow, instead of depending on Settings).
Federation tests are broken, I believe lemmy-js-client needs to be updated first to add the new API method. |
I'm not getting anything back from the requests:
Also this is the very first enum response, so I'm trying to debug what it looks like and if its possible to key on it. |
You need to put the correct, corresponding port, eg |
7155f9c
to
b198ebf
Compare
Ah, looks like it needs rebased again. |
Might be a bit before I add this to lemmy-UI. The webfinger requests require https, and working federation, which makes this a bit difficult to test.
|
b198ebf
to
251e0d3
Compare
It works fine using docker/federation, no https needed. Only thing to keep in mind is if you want to fetch an actor from lemmy-gamma, you need to open the instance in your browser first so it gets initialized. Also rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed, feel free to merge anytime.
Didnt even notice that your PR was against my branch again, so confusing 😂 |
Test with:
We can use this opportunity to move the functionality to a separate place in lemmy-ui, which should make it easier to discover and explain. Not sure exactly where that should be though.
This is a breaking change (maybe we should just create a label for that).