Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a GetComment endpoint. Fixes #1919 #1944

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Adding a GetComment endpoint. Fixes #1919 #1944

merged 1 commit into from
Nov 23, 2021

Conversation

dessalines
Copy link
Member

One thing, is that this doesn't serve them under /comment/123, but as /comment?id=123, just like post:

https://lemmy.ml/api/v3/post?id=93553

@Nutomic I'd rather that change on the apub side if possible, let me know.

@Nutomic
Copy link
Member

Nutomic commented Nov 23, 2021

The /comment/123 endpoint needs to be part of lemmy-ui, and return html. It doesnt matter what the api call looks like. So this is totally fine.

@dessalines dessalines marked this pull request as ready for review November 23, 2021 14:40
This was referenced Nov 23, 2021
Closed
Closed
@Nutomic Nutomic merged commit d2e28e5 into main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nutomic Nutomic Awaiting requested review from Nutomic Nutomic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dessalines @Nutomic