Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly read local SiteView #2122

Merged
merged 1 commit into from Mar 8, 2022
Merged

Correctly read local SiteView #2122

merged 1 commit into from Mar 8, 2022

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Mar 8, 2022

Happens because Lemmy now fetches site metadata from other instances, and SiteView::read wasnt sorting by id to get local site.

# select id, name from site;
id | name
----+-------
2 | DS9
1 | Lemmy

Deployed this code to enterprise.lemmy.ml (which had the same problem), and confirmed that it fixed the issue.

@Nutomic Nutomic requested a review from dessalines as a code owner March 8, 2022 12:22
@Nutomic
Copy link
Member Author

Nutomic commented Mar 8, 2022

Didnt want to merge and release an rc without review, so i fixed it another way. Downgraded the test instances to 0.15.2 (so they are currently broken), and manually deleted the DS9 entry from lemmy.ml database.

@dessalines dessalines merged commit 660efd1 into main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants