Use audience field to federate items in groups (fixes #2464) - #2584
Merged
Conversation
Nutomic
force-pushed
the
federation-audience
branch
from
November 24, 2022 12:46
85296d4 to
313fccd
Compare
Nutomic
marked this pull request as draft
November 24, 2022 14:59
Nutomic
force-pushed
the
federation-audience
branch
2 times, most recently
from
November 26, 2022 16:32
6eaf067 to
80261c3
Compare
Nutomic
marked this pull request as ready for review
November 26, 2022 16:33
Nutomic
force-pushed
the
federation-audience
branch
from
November 26, 2022 16:34
80261c3 to
e4c65da
Compare
dessalines
approved these changes
Dec 1, 2022
dessalines
left a comment
dessalines
left a comment
Member
There was a problem hiding this comment.
Not sure what to look for when its 70 files changed, but as long as tests are passing, then it should be fine.
| } | ||
|
|
||
| #[async_trait::async_trait(?Send)] | ||
| impl InCommunity for UpdateCommunity { |
Member
There was a problem hiding this comment.
This seems like its repeated a lot, could maybe be a default trait impl. Can worry about it later tho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the audience field for federation to all objects and activities which belong to a specific community. This is in accordance with FEP-1b12. Audience field is optional when receiving so this is fully backwards compatible.
Sadly it doesnt look like this will simplify the code, because we still have to verify that the community which is specified in
audiencefield matches other data. Eg when posting a comment, theaudiencecommunity has to match the community of the post.