New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activitypub crate rewrite #2782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
activitpub-crate-rewrite
branch
3 times, most recently
from
March 16, 2023 21:01
92e5ecc
to
6da6023
Compare
Nutomic
commented
Mar 16, 2023
dessalines
reviewed
Mar 17, 2023
Somehow this change has a very bad effect on compilation time for the lemmy_apub crate, went from 20s to 82s. No idea why, but will try to look into it later. Edit: based on the output of cargo-llvm-lines there is no difference in the llvm lines being generated, so its not a problem of big macro expansions. this branch:
main branch:
|
dessalines
approved these changes
Mar 21, 2023
Feel free to merge whenever you're ready. |
Nutomic
force-pushed
the
activitpub-crate-rewrite
branch
from
March 21, 2023 14:07
a09327e
to
a09223a
Compare
makotech222
added a commit
to hexbear-collective/lemmy
that referenced
this pull request
Mar 27, 2023
This reverts commit 6f51379.
makotech222
added a commit
to hexbear-collective/lemmy
that referenced
this pull request
Mar 27, 2023
This reverts commit 6cfc995.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is finished now. Took some effort to make things work and fix tests. But thanks to previous decoupling of apub and api crates it didnt require any changes in the api crates, otherwise this would have been even more complex.
See the docs for details how the activitypub crate works now: https://docs.rs/activitypub_federation