Remove last Option<Vec.. from API. Fixes #2820 #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
reviewed
Apr 19, 2023
| && !local_site_data | ||
| .allowed_instances | ||
| .iter() | ||
| .any(|i| domain.eq(&i.domain)) |
There was a problem hiding this comment.
The is_empty check isnt necessary.
There was a problem hiding this comment.
I'd thought it wasn't but it fails otherwise. You can check the previous failed CI attempts for that.
There was a problem hiding this comment.
I think you need to change it to if local_site_data.allowed_instances.iter().all(|i| domain.ne(&i.domain)) {
There was a problem hiding this comment.
That would check to make sure every instance in that allowlist is the domain to be checked. We only want to see if the one to be checked is there or not.
There was a problem hiding this comment.
Ah the is_empty is actually to check if allowlist mode is enabled, so it does require a separate check. Could you add a comment to explain that?
Nutomic
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only
Option<Vec<'s left, are the ones for create / edit API actions, which is correct because those should be optional.