Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ports used by docker #3012

Merged
merged 1 commit into from Jun 12, 2023
Merged

Fix ports used by docker #3012

merged 1 commit into from Jun 12, 2023

Conversation

pe1uca
Copy link
Contributor

@pe1uca pe1uca commented Jun 11, 2023

  • Update host docker port to 1236 as described in the documentation
  • Update container docker port to 1236 as used in the nginx.conf file
  • Removed exposed port 8536 from dockerfile as it's already handled by nginx.

@Nutomic
Copy link
Member

Nutomic commented Jun 12, 2023

Maybe it would be better to use port 80 for all containers? Its logical because its http, and means theres no need to lookup the port of each one separately. Of course this would require changes to docs and existing installations.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, we should've never merged the 80:80 one.

@Nutomic Its a test docker setup, so its best not to use 80 on our dev machines, which is nearly always going to have conflicts.

@Nutomic Nutomic enabled auto-merge (squash) June 12, 2023 21:57
@Nutomic Nutomic merged commit 932e65c into LemmyNet:main Jun 12, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants