Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split post and comment downvote enabling #3063

Closed
wants to merge 1 commit into from

Conversation

SekoiaTree
Copy link

Instead of downvotes being enabled or disabled completely by instance, it has been suggested to enable them for posts but disable them for comments.

Here's my attempt at coding that, but it's a draft because of the following issues:

  • I haven't been able to test it; in one way or another, the entire backend breaks from this (probably because I changed LocalSite). Maybe because of migrations, but I have no idea how those work.
    • Even without these changes, I can't log in to the admin account on the docker test, it just loads infinitely when I try to log in. Nothing in the logs.
  • There's a FIXME inside vote. See that comment
  • I'm not sure I like adding another setting, feels a bit cluttery. I would like extra opinions.

If you have any pointers for any of these 3 points, I'd love to hear them.

@Nutomic
Copy link
Member

Nutomic commented Jun 13, 2023

Why was this suggested and what advantage does it have? Seems like a lot of extra complication for almost no benefit.

@SekoiaTree
Copy link
Author

SekoiaTree commented Jun 13, 2023

Generally, there's a lot more comments than posts. Allowing downvotes in comments can mean you end up with downvote farmers and other such negativity, but it also blocks it for posts.

Allowing posts to be downvote still keeps the advantage of downvotes (a middle ground between "not upvoting something", which is mostly invisible, and reports, which should only be used if a rule is broken anyway), while avoiding problems with trolls.

I'd argue it's not much extra complexity, especially if it's dealt with correctly in the UI (button not even being visible for places where it can't be enabled). But yes, it can get a bit messy in the UI, which is why I have the third bulletpoint.

@dessalines
Copy link
Member

I'm not in favor of this either. Adds pointless complication, more work for front ends, and is arbitrary.

Allowing downvotes in comments can mean you end up with downvote farmers and other such negativity, but it also blocks it for posts.

Why would downvote farmers not do this for the other item?

@SekoiaTree
Copy link
Author

Why would downvote farmers not do this for the other item?
Because (bad) posts are a lot less visible. If I make a post, I get notifications about comments. But nobody gets notifications for posts. Also, more people will see bad comments on a good post than just a bad post (just by virtue of more people sorting by Hot/Active than New, which is the only way to easily see bad posts, and that's only when they're new).

But yeah if everybody's against it, I'll close this no problem. I definitely agree with the clutter.

@dessalines dessalines closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants