Handle displaying of deleted and removed posts/comments (fixes #2624)

[Nutomic]

Makes it so that deleted and removed posts/comments are only shown on the creator's profile page in the following cases:

• When user views his own profile, he can view all posts/comments which he deleted himself (but not those which were deleted by mod actions)
• When admin views user profile, he can see all posts/comments which were deleted by mod actions (but not those deleted by the user himself)

The existing code would also show deleted/removed posts and comments to admins/mods in post listings and search results, I dont think thats desirable.

[Nutomic]

Its a bit unclear what to do if the community was removed/deleted, we can revisit this if issues are reported in the future.

[dessalines]

The difficulty with this one, and why this really needs a SQL solution (that's better than my old one), is that the posts fetched are a collection of posts that might be yours + others.

With admins and mods, we can just show all deleted and removed. When its the creator, we need to do a join + filter.

[Nutomic]

With the current usage this is no problem as show_removed and show_deleted are only set on the user profile, so it will only include posts authored by that user. But if it ever gets set from somewhere else that will cause problems. As an admin I also dont want to see deleted and removed posts all over the frontpage, its pretty annoying.

As a kind of solution/workaround we could add a check that show_removed/show_deleted can only be true if creator_id is Some?

[dessalines]

As a kind of solution/workaround we could add a check that show_removed/show_deleted can only be true if creator_id is Some?

That creator_id filter is only called from the profile pages, so that means /home and /community would show deleted posts.

[Nutomic]

No because !self.show_removed.unwrap_or(false) with show_removed = None evaluates to !false which is true so the code in if is executed. Admittedly its confusing but its also covered by tests.

I changed the code now to avoid explicit show_removed/show_deleted parameters. If this looks better to you, I will also fix the tests.

[dessalines]

Yes it does look better.

[dessalines]

Once you get the tests passing, feel free to merge.

[dessalines]

Yes it does look better.

[Nutomic]

• did some cleanup for tests but not finished yet (still failing)
• changed it so that a user can always see their own deleted posts, not only in profile
• might be useful to show removed posts/comments in moderator view but not sure about this (Add moderator view parameter to list posts #3176)

[dessalines]

Clippy failing.

[Nutomic]

Need to merge #3613 first.

Edit: actually not, because this PR doesnt change PostView::read. So this is ready to merge

[Nutomic]

Added another change to allow returning own deleted posts from PostView::read, which makes #3613 obsolete. I tested to confirm that its working for unauthenticated users.