fix(api): Fix generating of TypeScript bindings #3331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lemmy_api_common crate makes use of the actix-rt attribute `#[actix_rt::test]`. Running `cargo test --features full` fails being unable to resolve the attribute. lemmy_api_common depends on actix-rt as a workspace dependency. The workspace dependency excluded default features - which currently is only the `macros` feature[1]. Dropping the `default-features = false` effectively includes the `macros` feature and resolves the full cargo test failing to resolve the test attribute. [1]: https://docs.rs/crate/actix-rt/2.8.0/features
|
This seems obsolete as actix_rt was replaced by tokio in #3158. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lemmy_api_common crate makes use of the actix-rt attribute
#[actix_rt::test]. Runningcargo test --features fullfails because it is unable to resolve the attribute.lemmy_api_common depends on actix-rt as a workspace dependency. The workspace dependency excludes default features - which currently is only the
macrosfeature1.Dropping the
default-features = falseeffectively includes themacrosfeature and resolves the full cargo test failing to resolve the test attribute.