Disable retry queue option #3468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cetra3
force-pushed
the
disable_retry_queue
branch
from
91bda74
to
cf1c4dd
Compare
dessalines
reviewed
Jul 3, 2023
| @@ -54,7 +54,7 @@ lemmy_routes = { version = "=0.18.1-rc.4", path = "./crates/routes" } | |||
| lemmy_db_views = { version = "=0.18.1-rc.4", path = "./crates/db_views" } | |||
| lemmy_db_views_actor = { version = "=0.18.1-rc.4", path = "./crates/db_views_actor" } | |||
| lemmy_db_views_moderator = { version = "=0.18.1-rc.4", path = "./crates/db_views_moderator" } | |||
| activitypub_federation = { version = "0.4.4", default-features = false, features = ["actix-web"] } | |||
| activitypub_federation = { git = "https://github.com/cetra3/activitypub-federation-rust.git", branch = "disable_retry_queue" } | |||
There was a problem hiding this comment.
I'd just wait for this to get merged.
This comment was marked as abuse.
This comment was marked as abuse.
|
@RocketDerp I need to explain/adjust this a bit more, there is at least 2 attempts before it goes into the retry queue, but those 2 attempts share the same payload because they happen about 1 minute apart & don't need to be re-signed. |
This comment was marked as abuse.
This comment was marked as abuse.
|
This hasnt helped with performance afaik, so no reason to merge it. Can be useful for testing though. #3427 will properly fix excessive retries. |
|
Edit: This doesn't appear to have impacted perf according to the chat, so might be good to close this one off after confirming? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.