-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federation tests replication round1 - demonstrate absent replication of comment deletes #3657
Merged
Nutomic
merged 18 commits into
LemmyNet:main
from
RocketDerp:federation_tests_replication_round1
Jul 27, 2023
Merged
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
fb7df85
more robust test of unlike a comment, confirm replication to instance…
RocketDerp 83cdac2
more robust 'delete a comment' test, confirm replication
RocketDerp 7bd3b20
Far more robust "Report a comment" test. Many comments about situatio…
RocketDerp 7dfb6ee
typo and actually have Gamma comment check use gamma, not alpha
RocketDerp 0384675
prepare-drone-federation-test.sh has some more echo output and note a…
RocketDerp 9f742e2
Add http cache for webfingers (#3317)
cetra3 9769721
Merge branch 'main' into RocketDerp-federation_tests_replication_round1
Nutomic 71d5ae7
Rewrite activity lists to fix delete federation (fixes #3625)
Nutomic 5cd2852
Revert "typo and actually have Gamma comment check use gamma, not alpha"
RocketDerp a72590b
Revert "Far more robust "Report a comment" test. Many comments about …
RocketDerp 6c74f9f
Merge branch 'LemmyNet:main' into federation_tests_replication_round1
RocketDerp fb32d19
Merge branch 'LemmyNet:main' into federation_tests_replication_round1
RocketDerp 24f3d02
prettier TypeScript
RocketDerp bdb7381
revised comments, as ResolveObject isn't using routine replication
RocketDerp 46b7e6a
fmt
Nutomic a3658a9
Merge branch 'main' into federation_tests_replication_round1
dessalines 9cb9ca3
fix api tests
Nutomic 4e741fb
remove comment
Nutomic File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isnt really testing replication. If the comment failed to be federated, resolve will fetch it instead. You could instead use resolvePost and then getComments for that post to check if its included there. Or add a new getComments variant which retrieves all newest comments for the whole instance.
This comment was marked as abuse.
Sorry, something went wrong.