Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit local instance from federated instances list #3712

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Omit local instance from federated instances list #3712

merged 3 commits into from
Jul 27, 2023

Conversation

baod-rate
Copy link
Contributor

Fixes #2985

@baod-rate
Copy link
Contributor Author

whoops, this broke the federation tests. investigating it

@baod-rate baod-rate marked this pull request as draft July 25, 2023 21:57
@Nutomic
Copy link
Member

Nutomic commented Jul 26, 2023

I can reproduce the test failure. Its very odd because this function is only used for the GetFederatedInstances API call which isnt being used anywhere in the tests.

Nutomic added a commit that referenced this pull request Jul 26, 2023
@Nutomic
Skip fragile API tests
e3b66ba 
These tests fail very often for no reason, eg in #3712 and #3696.
Better to disable them until they can be fixed.
@Nutomic Nutomic mentioned this pull request Jul 26, 2023
Merged
dessalines pushed a commit that referenced this pull request Jul 26, 2023
@Nutomic
Skip fragile API tests (#3723)
afac3ee 
* Skip fragile API tests

These tests fail very often for no reason, eg in #3712 and #3696.
Better to disable them until they can be fixed.

* killall -s1
@baod-rate baod-rate marked this pull request as ready for review July 27, 2023 02:07
Nutomic added a commit that referenced this pull request Jul 27, 2023
@Nutomic
Skip fragile API tests (#3723)
2dbb6ff 
* Skip fragile API tests

These tests fail very often for no reason, eg in #3712 and #3696.
Better to disable them until they can be fixed.

* killall -s1
@Nutomic Nutomic merged commit 2d7b416 into LemmyNet:main Jul 27, 2023
1 check passed
Nutomic added a commit that referenced this pull request Jul 27, 2023
@baod-rate @Nutomic
Omit local instance from federated instances list (#3712)
ddead8d 
Co-authored-by: Nutomic <me@nutomic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines left review comments

@Nutomic Nutomic Nutomic approved these changes

@phiresky phiresky Awaiting requested review from phiresky phiresky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Federated instance list contains current instance
3 participants
@baod-rate @Nutomic @dessalines