-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make resolve_object not require auth #3685 #3716
Merged
dessalines
merged 3 commits into
LemmyNet:main
from
marsara9:feature/resolve-object-auth-changes
Jul 26, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,18 @@ pub(crate) async fn search_query_to_object_id( | |
}) | ||
} | ||
|
||
/// Converts a search query to an object id. The query MUST bbe a URL which will bbe treated | ||
/// as the ObjectId directly. If the query is a webfinger identifier (@user@example.com or | ||
/// !community@example.com) this method will return an error. | ||
#[tracing::instrument(skip_all)] | ||
pub(crate) async fn search_query_to_object_id_local( | ||
query: &str, | ||
context: &Data<LemmyContext>, | ||
) -> Result<SearchableObjects, LemmyError> { | ||
let url = Url::parse(query)?; | ||
ObjectId::from(url).dereference_local(context).await | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can directly call |
||
} | ||
|
||
/// The types of ActivityPub objects that can be fetched directly by searching for their ID. | ||
#[derive(Debug)] | ||
pub(crate) enum SearchableObjects { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API change, but it shouldn't be breaking.