Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove n^2 part of person triggers, improve community aggregate trigger #3739

Merged
merged 3 commits into from Jul 27, 2023
Merged

remove n^2 part of person triggers, improve community aggregate trigger #3739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e944c4
remove n^2 part of person triggers, improve community aggregate trigger
phiresky Jul 27, 2023
2cbd17e
comment out comment_score tests since previously they only accidental…
phiresky Jul 27, 2023
a14a4c9
empty
phiresky Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions crates/db_schema/src/aggregates/person_aggregates.rs
View file
Open in desktop
Expand Up @@ -161,7 +161,8 @@ mod tests {
.await
.unwrap();
assert_eq!(0, after_parent_comment_removed.comment_count);
assert_eq!(0, after_parent_comment_removed.comment_score);
// TODO: fix person aggregate comment score calculation
// assert_eq!(0, after_parent_comment_removed.comment_score);

// Remove a parent comment (the scores should also be removed)
Comment::delete(pool, inserted_comment.id).await.unwrap();
Expand All @@ -172,7 +173,8 @@ mod tests {
.await
.unwrap();
assert_eq!(0, after_parent_comment_delete.comment_count);
assert_eq!(0, after_parent_comment_delete.comment_score);
// TODO: fix person aggregate comment score calculation
// assert_eq!(0, after_parent_comment_delete.comment_score);

// Add in the two comments again, then delete the post.
let new_parent_comment = Comment::create(pool, &comment_form, None).await.unwrap();
Expand All @@ -186,13 +188,15 @@ mod tests {
.await
.unwrap();
assert_eq!(2, after_comment_add.comment_count);
assert_eq!(1, after_comment_add.comment_score);
// TODO: fix person aggregate comment score calculation
// assert_eq!(1, after_comment_add.comment_score);

Post::delete(pool, inserted_post.id).await.unwrap();
let after_post_delete = PersonAggregates::read(pool, inserted_person.id)
.await
.unwrap();
assert_eq!(0, after_post_delete.comment_score);
// TODO: fix person aggregate comment score calculation
// assert_eq!(0, after_post_delete.comment_score);
assert_eq!(0, after_post_delete.comment_count);
assert_eq!(0, after_post_delete.post_score);
assert_eq!(0, after_post_delete.post_count);
Expand Down
80 changes: 80 additions & 0 deletions migrations/2023-07-27-134652_remove-expensive-broken-trigger/down.sql
View file
Open in desktop
@@ -0,0 +1,80 @@
create or replace function person_aggregates_comment_count()
returns trigger language plpgsql
as $$
begin
IF (was_restored_or_created(TG_OP, OLD, NEW)) THEN
update person_aggregates
set comment_count = comment_count + 1 where person_id = NEW.creator_id;
ELSIF (was_removed_or_deleted(TG_OP, OLD, NEW)) THEN
update person_aggregates
set comment_count = comment_count - 1 where person_id = OLD.creator_id;

-- If the comment gets deleted, the score calculation trigger won't fire,
-- so you need to re-calculate
update person_aggregates ua
set comment_score = cd.score
from (
select u.id,
coalesce(0, sum(cl.score)) as score
-- User join because comments could be empty
from person u
left join comment c on u.id = c.creator_id and c.deleted = 'f' and c.removed = 'f'
left join comment_like cl on c.id = cl.comment_id
group by u.id
) cd
where ua.person_id = OLD.creator_id;
END IF;
return null;
end $$;

create or replace function person_aggregates_post_count()
returns trigger language plpgsql
as $$
begin
IF (was_restored_or_created(TG_OP, OLD, NEW)) THEN
update person_aggregates
set post_count = post_count + 1 where person_id = NEW.creator_id;

ELSIF (was_removed_or_deleted(TG_OP, OLD, NEW)) THEN
update person_aggregates
set post_count = post_count - 1 where person_id = OLD.creator_id;

-- If the post gets deleted, the score calculation trigger won't fire,
-- so you need to re-calculate
update person_aggregates ua
set post_score = pd.score
from (
select u.id,
coalesce(0, sum(pl.score)) as score
-- User join because posts could be empty
from person u
left join post p on u.id = p.creator_id and p.deleted = 'f' and p.removed = 'f'
left join post_like pl on p.id = pl.post_id
group by u.id
) pd
where ua.person_id = OLD.creator_id;

END IF;
return null;
end $$;

create or replace function community_aggregates_comment_count()
returns trigger language plpgsql
as $$
begin
IF (was_restored_or_created(TG_OP, OLD, NEW)) THEN
update community_aggregates ca
set comments = comments + 1 from comment c, post p
where p.id = c.post_id
and p.id = NEW.post_id
and ca.community_id = p.community_id;
ELSIF (was_removed_or_deleted(TG_OP, OLD, NEW)) THEN
update community_aggregates ca
set comments = comments - 1 from comment c, post p
where p.id = c.post_id
and p.id = OLD.post_id
and ca.community_id = p.community_id;

END IF;
return null;
end $$;
47 changes: 47 additions & 0 deletions migrations/2023-07-27-134652_remove-expensive-broken-trigger/up.sql
View file
Open in desktop
@@ -0,0 +1,47 @@
create or replace function person_aggregates_comment_count()
returns trigger language plpgsql
as $$
begin
IF (was_restored_or_created(TG_OP, OLD, NEW)) THEN
update person_aggregates
set comment_count = comment_count + 1 where person_id = NEW.creator_id;
ELSIF (was_removed_or_deleted(TG_OP, OLD, NEW)) THEN
update person_aggregates
set comment_count = comment_count - 1 where person_id = OLD.creator_id;
END IF;
return null;
end $$;

create or replace function person_aggregates_post_count()
returns trigger language plpgsql
as $$
begin
IF (was_restored_or_created(TG_OP, OLD, NEW)) THEN
update person_aggregates
set post_count = post_count + 1 where person_id = NEW.creator_id;

ELSIF (was_removed_or_deleted(TG_OP, OLD, NEW)) THEN
update person_aggregates
set post_count = post_count - 1 where person_id = OLD.creator_id;
END IF;
return null;
end $$;

create or replace function community_aggregates_comment_count()
returns trigger language plpgsql
as $$
begin
IF (was_restored_or_created(TG_OP, OLD, NEW)) THEN
update community_aggregates ca
set comments = comments + 1 from post p
where p.id = NEW.post_id
and ca.community_id = p.community_id;
ELSIF (was_removed_or_deleted(TG_OP, OLD, NEW)) THEN
update community_aggregates ca
set comments = comments - 1 from post p
where p.id = OLD.post_id
and ca.community_id = p.community_id;

END IF;
return null;
end $$;