Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix federation of admin actions (fixes #3980) #3988

Merged
merged 3 commits into from Sep 26, 2023

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Sep 25, 2023

Lemmy is not correctly verifying federated mod actions which are performed by instance admins. Instead of checking that the mod action comes from the community instance, it was comparing against the object instance. This works fine as long as the affected object is located on the community instance, but fails in case of remote objects. This PR fixes the behaviour and changes the test case to verify this.

This is a major issue with moderation, we should consider publishing the fix in an 0.18.5 release.

@Nothing4You
Copy link
Contributor

Nothing4You commented Sep 25, 2023

do i understand it correctly that now the user's instance admin is no longer able to remove a user's posts (with federation)?
is this intentional and by design?

a malicious/compromised instance can already spoof removals to be federated as removed by user when it's removed by an admin of the user's instance, so there would not be any federation trust impact from allowing this.

edit for clarification:

example use cases for this: someone registers an account purely for harassment, such as spamming, posting untagged nsfw content in non-nsfw communities and other similar things.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the cherry-picking isn't too bad for this one if we want to do a 0.18.5 release.

@dessalines dessalines merged commit 5058911 into main Sep 26, 2023
0 of 2 checks passed
Nutomic added a commit that referenced this pull request Sep 26, 2023
* Fix federation of admin actions (fixes #3980)

* clippy

---------

Co-authored-by: Dessalines <tyhou13@gmx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants