Fix federation of admin actions (fixes #3980) #3988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lemmy is not correctly verifying federated mod actions which are performed by instance admins. Instead of checking that the mod action comes from the community instance, it was comparing against the object instance. This works fine as long as the affected object is located on the community instance, but fails in case of remote objects. This PR fixes the behaviour and changes the test case to verify this.
This is a major issue with moderation, we should consider publishing the fix in an 0.18.5 release.