Fix following local communities stuck on pending (fixes #4160) #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
commented
Nov 15, 2023
| }; | ||
| CommunityFollower::follow(&mut context.pool(), &community_follower_form) | ||
| .await | ||
| .ok(); |
There was a problem hiding this comment.
This federation send function was called even for local communities, which would overwrite the value of subscribed and change it back to pending. In fact it is completely unnecessary because the api already sets pending for remote community follows.
Nutomic
force-pushed
the
fix-local-follow
branch
from
7a2e655
to
52cc657
Compare
dessalines
reviewed
Nov 15, 2023
dessalines
approved these changes
Nov 17, 2023
4 tasks
Nutomic
force-pushed
the
fix-local-follow
branch
from
3be7b83
to
920dbab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.