Add local_subscribers field to CommunityAggregates. Fixes #4144

[ismailkarsli]

I gave it a try.

[ismailkarsli]

I couldn't get the local_subscriber tests right. If you have any suggestions where to do it, I can try.

[ismailkarsli]

Pls some feedbacks lol

[dessalines]

See above. LMK if you need any help with this.

[ismailkarsli]

I won't be able to complete this right now. Closing it to not keep stale.

[ismailkarsli]

Add this trigger

CREATE FUNCTION delete_follow_before_person ()
    RETURNS TRIGGER
    LANGUAGE plpgsql
    AS $$
BEGIN
    DELETE FROM community_follower AS c
    WHERE c.person_id = OLD.id;
    RETURN OLD;
END;
$$;

CREATE TRIGGER delete_follow
    BEFORE DELETE ON person
    FOR EACH ROW
    EXECUTE FUNCTION delete_follow_before_person ();

Wait I've read this more carefully and it looks brilliant! It deletes follows before deleting person, which is better than duplicating same trigger. Absolutely better than my first solution idea 👌

[ismailkarsli]

Federation tests work when I test them locally with yalc, so there is no problem with the tests right now.

[dessalines]

I've deployed this now too, so you can add it to the package.json :

lemmy-js-client: 0.19.2-alpha.2

[ismailkarsli]

Even though follow tests passed, federation tests gave the error below. It could be temporary or maybe about new lemmy-js-client. I'll check tomorrow.

/woodpecker/src/github.com/LemmyNet/lemmy/api_tests/node_modules/node-fetch/lib/index.js:1501
			reject(new FetchError(`request to ${request.url} failed, reason: ${err.message}`, 'system', err));
			       ^
FetchError {
  message: 'request to http://127.0.0.1:8541/api/v3/site? failed, reason: socket hang up',
  type: 'system',
  errno: 'ECONNRESET',
  code: 'ECONNRESET'
}

[ismailkarsli]

And yeah, it passed today without any changes.

[dessalines]

LGTM, thx!

Lets have @phiresky take a look also.