Fix #4048, return an error if post title is longer than 200 characters #4188
Conversation
varshard
requested review from
Nutomic,
dessalines and
phiresky
as code owners
| @@ -56,6 +55,7 @@ pub async fn create_post( | |||
| let url = data_url.map(clean_url_params).map(Into::into); // TODO no good way to handle a "clear" | |||
|
|
|||
| is_valid_post_title(&data.name)?; | |||
There was a problem hiding this comment.
This function already has a check for 200 char maximum length using this regex. But the regex is wrong, it should be something like ^\S{3,200}$ instead. You can change that and add keep your test cases to ensure that its working. I dont think the separate error type for invalid title length is necessary.
There was a problem hiding this comment.
Thank you. I shoul've check the regexp.
Look like ^\S{3,200}$ won't work, though. It would reject if a post title contains any space.
There was a problem hiding this comment.
@Nutomic How about ^\s?.{3,200}\s?$ instead?
There was a problem hiding this comment.
Right Im not so familiar with regex shorthands. Your suggestion makes more sense, but instead of \s? you can just call trim() so that leading and trailing spaces are removed, not written to db. Also there is no reason to close this PR, you can add more commits to make these changes.
Actually if the regex only checks for string length, it can be removed and replaced with simple comparison of .len().
|
The infinite loading when submitting a post with too long title is a problem in lemmy-ui. I commented in LemmyNet/lemmy-ui#2227 and moved it to lemmy-ui. |
Fix #4048.
Prevalidate that a post title is longer than 200 characters, which is the length of the post name column on the database. So, that Lemmy could handle the error more gracefully.