New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing test cleanup #4289
Add missing test cleanup #4289
Conversation
Person::delete(pool, timmy.id).await.unwrap(); | ||
Person::delete(pool, sara.id).await.unwrap(); | ||
Person::delete(pool, jess.id).await.unwrap(); | ||
Instance::delete(pool, instance.id).await.unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to on delete cascade
it would be enough to call only Instance::delete
here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that should work fine.
Person::delete(pool, timmy.id).await.unwrap(); | ||
Person::delete(pool, sara.id).await.unwrap(); | ||
Person::delete(pool, jess.id).await.unwrap(); | ||
Instance::delete(pool, instance.id).await.unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that should work fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge after running fmt
* Add missing test cleanup * cleanup
* Add missing test cleanup * cleanup
Followup for #4275. This test failure showed the extra usernames.