Add support for RSS media enclosures in feeds #4442
Conversation
crates/routes/src/feeds.rs
Outdated
| enclosure.set_length("0".to_string()); | ||
| enclosure | ||
| }); | ||
| } |
There was a problem hiding this comment.
Use post.url_content_type instead which was recently added. For length you might as well leave the default value (empty string), probably causes less confusion.
There was a problem hiding this comment.
Thanks for the feedback, I switched to post.url_content_type but left the 0 as its from the specification:
When an enclosure's size cannot be determined, a publisher should use a length of 0.
https://www.rssboard.org/rss-profile#element-channel-item-enclosure
There was a problem hiding this comment.
Its still using mime_guess, did you forget to push your changes?
There was a problem hiding this comment.
Ah sorry I misunderstood you, I just pushed a commit to make proper use of it, let me know what you think.
|
Thank you! |
Until now the generated RSS feeds would not include a media enclosure if the post in question contains a link to a media file.
Adding this allows for RSS readers to display the media content directly inside of the item instead of just the link.
In order to specify an enclosure we need to give the MIME type of the media. As we cannot fetch the media we just use the url in order to guess it. If it doesn't work we specify it as octet stream which is a universal fallback.
Please let me know if you have any feedback.
Specification: