Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly synchronize collection of community featured posts #4475

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Feb 26, 2024

We have a collection for synchronizing featured posts when a community gets fetched, but it turns out that was totally broken. First of all the collection wasnt fetched at all. Then the posts werent marked as featured in the db. This PR fixes it, Ive tested it manually.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably be good to add tests, but that can always be done later.

@dessalines dessalines merged commit 7316dd2 into main Feb 26, 2024
2 checks passed
Nutomic added a commit that referenced this pull request Feb 27, 2024
* Correctly synchronize collection of community featured posts (fixes #3867)

* Add api test for synchronizing featured posts (ref #4475)

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants