Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt_text for posts. Fixes #1086 #4477

Merged
merged 11 commits into from Mar 5, 2024
Merged

Add alt_text for posts. Fixes #1086 #4477

merged 11 commits into from Mar 5, 2024

Conversation

dessalines
Copy link
Member

No description provided.

@Nutomic
Copy link
Member

Nutomic commented Feb 28, 2024

This will also need some coverage in api tests (by adding alt text in an existing test).

@rimu
Copy link

rimu commented Mar 2, 2024

If I read this right, you're going to federate alt text using a field called 'name' on the Image?

The structure of the Activity is already totally different to Mastodon so copying their weird usage of 'name' seems kinda useless?

@rimu
Copy link

rimu commented Mar 2, 2024

FYI PieFed does alt text using altText on the Image, like this:

curl -H "Accept: application/activity+json" https://piefed.social/post/39624 | jq

I hope you do the same but I'll adjust PieFed to work with whatever you decide.

@dessalines
Copy link
Member Author

Currently its the name field on the attachment, similar to this: curl -H "Accept: application/activity+json" https://twit.social/@glennf/112004543167309282 | jq

@Nutomic
Copy link
Member

Nutomic commented Mar 4, 2024

Yes lets follow Mastodon on this because they are very unlikely to change their format for us. Also its better to use standard fields when possible.

@Nutomic Nutomic merged commit 7f9950f into main Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants