Fix rate limiter #4560
Merged
Fix rate limiter #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunaurus
requested review from
Nutomic,
dessalines,
phiresky and
dullbananas
as code owners
|
(Tested on lemm.ee, my rate limits are functional again after applying this) |
dullbananas
approved these changes
Mar 21, 2024
|
Don't be too hard on yourself 😄 It's a really easy mistake to make & quite hard to spot during testing |
Sending hugs |
Nutomic
approved these changes
Mar 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rate limiters are not working due to a bug in
remove_full_bucketswhich causes all buckets to be removed every time it is called. This PR fixes the bug.Includes a few additional tests for this particular case as well.