Avoid breaking api change, reduce api cache duration #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
Nutomic
changed the title
serde(skip) to avoid breaking change
SleeplessOne1917
approved these changes
Apr 9, 2024
dessalines
approved these changes
Apr 9, 2024
| @@ -36,7 +36,7 @@ pub struct Site { | |||
| pub inbox_url: DbUrl, | |||
| #[serde(skip)] | |||
| pub private_key: Option<String>, | |||
| #[serde(skip)] | |||
| // TODO: mark as `serde(skip)` in next major release as its not needed for api | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serde(skip)to avoid breaking change/site/v3/siteto 60s which was not intended. This changes it back to 1s.