Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all Result<..., LemmyError> into LemmyResult<...> Fixes #4613 #4614

Merged
merged 2 commits into from Apr 10, 2024

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Apr 9, 2024

Cleanup task to remove all Result<.., LemmyError> into LemmyResult<...>

Copy link
Member

@Nutomic Nutomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is any way we can show a warning when using LemmyError directly.

@phiresky
Copy link
Collaborator

show a warning when using LemmyError directly

It might be possible to not export the type directly?

@dessalines
Copy link
Member Author

Unfortunately LemmyError still required in a few places, namely on some actix::Results.

I've been grepping like rg "LemmyError>" , and there aren't any more ones I can do. Most importantly new copy-pasted code will use this LemmyResult standard.

@dessalines dessalines merged commit 5dea21d into main Apr 10, 2024
2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the cleanup_lemmy_results branch April 10, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants