Testing for federation with NodeBB, make community.followers_url optional #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
Nutomic
force-pushed
the
nodebb-federation
branch
from
6e79c54
to
5b99e99
Compare
| .await | ||
| .ok(); | ||
| if let Some(followers) = group.followers { | ||
| followers.dereference(&community_, &context_).await.ok(); |
There was a problem hiding this comment.
I'm not familiar with the dereference function and I couldn't find docs for it. I figure it's related to the dereference operator *?
There was a problem hiding this comment.
Probably from a trait in the activitypub_federation crate
There was a problem hiding this comment.
dessalines
reviewed
Apr 16, 2024
| @@ -49,8 +49,8 @@ pub struct Community { | |||
| /// A URL for a banner. | |||
| pub banner: Option<DbUrl>, | |||
| #[cfg_attr(feature = "full", ts(skip))] | |||
| #[serde(skip, default = "placeholder_apub_url")] | |||
| pub followers_url: DbUrl, | |||
| #[serde(skip)] | |||
There was a problem hiding this comment.
No breaking change since its skipped anyway.
dessalines
approved these changes
Apr 16, 2024
dullbananas
approved these changes
Apr 27, 2024
SleeplessOne1917
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeBB doesnt have the
followersfield for community. This field is also not mandatory in the Activitypub standard, so we need to drop the requirement in Lemmy as well.See https://community.nodebb.org/category/30/activitypub