Add timeout for processing incoming activities #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
dessalines
reviewed
May 7, 2024
crates/apub/src/http/mod.rs
Outdated
| // avoid taking a long time to process an incoming activity when a required data fetch times out. | ||
| // In this case our own instance would timeout and be marked as dead by the sender. Better to | ||
| // consider the activity broken and move on. | ||
| timeout(Duration::from_secs(9), receive_fut) |
There was a problem hiding this comment.
Probably should make this a const, or even better, externalize it into a setting in config.hjson
dullbananas
approved these changes
May 7, 2024
dessalines
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.