Stop using a diesel_cli docker image, use cargo-install in woodpecker. #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dessalines
commented
May 16, 2024
dessalines
commented
- The diesel_cli image is 500MB, and rebuilt daily. Much easier to use binstall to install it.
- The diesel_cli image is 500MB, and rebuilt daily. Much easier to use binstall to install it.
dessalines
requested review from
Nutomic,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
dessalines
commented
May 16, 2024
.woodpecker.yml
Outdated
| @@ -79,9 +79,11 @@ steps: | |||
| cargo_machete: | |||
| image: rustlang/rust:nightly | |||
| commands: | |||
| # Install cargo binstall | |||
| - wget https://github.com/cargo-bins/cargo-binstall/releases/latest/download/cargo-binstall-x86_64-unknown-linux-musl.tgz | |||
There was a problem hiding this comment.
Not sure if there's a way to extract and run multiple lines in yaml... if anyone knows how to do this that'd be appreciated.
dullbananas
reviewed
May 16, 2024
.woodpecker.yml
Outdated
| # Install cargo binstall | ||
| - wget https://github.com/cargo-bins/cargo-binstall/releases/latest/download/cargo-binstall-x86_64-unknown-linux-musl.tgz | ||
| - tar -xvf cargo-binstall-x86_64-unknown-linux-musl.tgz | ||
| - cp cargo-binstall /usr/local/cargo/bin |
There was a problem hiding this comment.
Wget and tar should not need to be run again. It might be possible to also remove cp and replace cargo binstall with ./cargo-binstall.
SleeplessOne1917
approved these changes
May 16, 2024
|
Alright I wasted a shameful amount of time on this:
|
dessalines
changed the title
dullbananas
approved these changes
May 16, 2024
| environment: | ||
| CARGO_HOME: .cargo_home | ||
| DATABASE_URL: postgres://lemmy:password@database:5432/lemmy | ||
| commands: | ||
| - <<: *install_diesel_cli | ||
| - diesel migration run | ||
| - diesel print-schema --config-file=diesel.toml > tmp.schema |
There was a problem hiding this comment.
After #4673 is finished, this will be the only place where diesel cli is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.