Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header logo from site.banner (ref #24) #41

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Add header logo from site.banner (ref #24) #41

merged 3 commits into from
Nov 2, 2022

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Nov 2, 2022

For now you need to set the logo in lemmyui admin settings (called banner). It needs to be 149px wide and 52px high, otherwise it will be cut off.

@Nutomic Nutomic mentioned this pull request Nov 2, 2022
@Tealk
Copy link
Collaborator

Tealk commented Nov 2, 2022

I would have even started something once
https://github.com/LemmyNet/lemmyBB/tree/custom-logo

@Nutomic
Copy link
Member Author

Nutomic commented Nov 2, 2022

There is no need to use an env var for this as we can just store data via Lemmy which is much cleaner.

@Tealk
Copy link
Collaborator

Tealk commented Nov 2, 2022

I didn't know that at the time, but I even removed it in the last commit.
but it is still missing css so that the design is not destroyed.

//Edit
i just see you used inline css, no please not thats terrible and this is a travel problem for csp

Why: is not a nice handling and makes problems with csp
@Tealk
Copy link
Collaborator

Tealk commented Nov 2, 2022

It needs to be 149px wide and 52px high, otherwise it will be cut off.

Not anymore, the size is now adjusted

image

@Nutomic
Copy link
Member Author

Nutomic commented Nov 2, 2022

Thanks! But you accidentally pushed a change to the translations submodule, i had to revert that.

@Nutomic Nutomic merged commit 68b9f76 into main Nov 2, 2022
@Nutomic Nutomic deleted the site-logo branch November 2, 2022 14:17
@Nutomic Nutomic restored the site-logo branch November 4, 2022 14:58
@Nutomic Nutomic deleted the site-logo branch November 4, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants