Redux support #8
Conversation
… well combined with redux
| const loadMember = (id : number) => { | ||
| return { | ||
| type: 'MEMBER_LOAD' | ||
| ,id: id |
There was a problem hiding this comment.
Usually it puts the comma at the end of the previous line
There was a problem hiding this comment.
We have to find an standard way, I like to place it at the beginning, because when I remove a line sometimes I get a mess (error).
| var memberIdNumber : number = parseInt(memberId); | ||
| this.props.loadMember(memberIdNumber); | ||
| } else { | ||
| this.props.newMember(); |
There was a problem hiding this comment.
I think that rename to 'initializeNewMember' is more explicit.
What do you think?
| if(errorsSave.isEntityValid == true) { | ||
| MemberAPI.saveAuthor(state.member); | ||
| // TODO: pending clone member object !! (keep state inmmutable) | ||
| newState = objectAssign({}, state, {isValid: true, saveCompleted: true, errors: new MemberFormErrors()}); |
There was a problem hiding this comment.
Where are you using state.isValid property?
There was a problem hiding this comment.
I think that you only need to update the field saveCompleted because your are initializing errors field in 'MEMBER_LOAD' case
newState = objectAssign({}, state, {saveCompleted: true});
There was a problem hiding this comment.
That's true if we are able to save all that is not needed
| let newMember : MemberEntity = objectAssign({}, state.member, {}); | ||
| newMember[fieldName] = value; | ||
|
|
||
| newState = objectAssign({}, state, {member: newMember, dirty: true}); |
There was a problem hiding this comment.
Where are you using state.dirty property?
There was a problem hiding this comment.
That's another point I would leave it as it is now, and later on we add e.g. a function that ask you when you navigate away fro mthe page, if there are pending changes to save.
Added sample 09, redux support, using fake api (sync).