Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code folding markers #11

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Add code folding markers #11

merged 1 commit into from
Jul 26, 2018

Conversation

zacharylawrence
Copy link
Contributor

@zacharylawrence zacharylawrence commented Jul 22, 2018

Following the recommendations here, it seems like ;#region fits the best.

Since lines with non-valid beancount syntax are ignored, one alternative would be to directly use #region. However, using explicit comments seems cleaner to me and provides better syntax highlighting (if going down this route, new syntax highlighting could be added).

See: https://code.visualstudio.com/docs/extensionAPI/extension-points#_contributeslanguages
Fixes #5

@zacharylawrence
Copy link
Contributor Author

zacharylawrence commented Jul 22, 2018

The solution proposed in #5 doesn't work for beancount syntax that breaks when indented (ex: open commands directly below one another).

@Lencerf Lencerf merged commit 147b04d into Lencerf:master Jul 26, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants