Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new switch, --only-generate. This will only create the search.json, won't upload it. #4

Merged
merged 3 commits into from
Feb 24, 2015

Conversation

bsclifton
Copy link
Contributor

This is a minimal version of #3

…nly because they were breaking for me (I'm on Windows, likely a config on my side broken).
@bsclifton bsclifton changed the title Adding a new switch, --only_generate. This will only create the search.json, won't upload it. Adding a new switch, --only-generate. This will only create the search.json, won't upload it. Feb 23, 2015
@bsclifton
Copy link
Contributor Author

@LeonB, just some context; we're re-working some of the Ember.js documentation and would like to use this plugin. I've been testing the new flag added by this (originally added by @Jberlinsky) and it's working great. Let me know if I can do anything to expedite acceptance of this PR 😄 I've tried to keep it extremely simple

@trek
Copy link

trek commented Feb 24, 2015

👍 this lets us move forward, but we still need to polish towards what originally we spec'ed out. Things still missing or done in a way that needs cleaup:

  • search.json is an array. It needs to be a key of documents that holds the array.
  • "provide a swiftype:generate command that outputs a search.json file" A thor subcommand is probably the more idiomatic way structure this public API. A cli Middleman plugin (like rake, capistrano and other parts of the ruby ecosystem) tends to group plugins instead of switching on flags
  • "search.json file goes into the build directory on middleman build and middleman server". Right now you need to run the command separately instead of it just happening when you build or server.
  • "tests must exist around all this behavior to avoid future breakage". We still need tests a around the generation of the search.json file

LeonB added a commit that referenced this pull request Feb 24, 2015
Adding a new switch, --only-generate. This will only create the search.json, won't upload it.
@LeonB LeonB merged commit 6da40c1 into LeonB:master Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants