Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow search.json generation separate from Swiftype upload #3

Merged
merged 1 commit into from
Feb 25, 2015

Conversation

Jberlinsky
Copy link
Contributor

Inspired by emberjs/guides#2. Adds a command-line flag --only-generate to middleman swiftype that will place search.json in the source/ directory.

Also starts to add testing around Swiftype upload functionality. These are tagged with @wip because I couldn't seem to stub out Swiftype::Client while executing it via the Cucumber steps.

@trek
Copy link

trek commented Feb 21, 2015

Also starts to add testing around Swiftype upload functionality.

That is probably its own PR, yeah?

@bsclifton
Copy link
Contributor

@Jberlinsky can you break out the testing (around Swiftype upload) into a separate PR (and remove from this)? Should help speed up acceptance of this :)

@bsclifton
Copy link
Contributor

@Jberlinsky I broke the first bit of your PR into #4

I did some testing and incorporated feedback from @trek; looking great :) Didn't mean to step on your toes, just trying to keep it simple. Awesome job BTW 👍

@Jberlinsky
Copy link
Contributor Author

@bsclifton Thanks for the assist :)

@LeonB
Copy link
Owner

LeonB commented Feb 24, 2015

Hi guys. Looks great! Should I accept #3 or #4?

@bsclifton
Copy link
Contributor

#4 would be ideal :) Then @Jberlinsky could merge (if you don't mind) and his PR #3 adds more testing :)

@LeonB
Copy link
Owner

LeonB commented Feb 24, 2015

Done. Don't mind at all. My repo is you repo :)

@bsclifton
Copy link
Contributor

Awesome; @Jberlinsky, if you were able to merge (I only had to make a few changes; for example, changing the source directory to the build directory), your PR is ready to go :)

@Jberlinsky
Copy link
Contributor Author

@bsclifton All set! cc @LeonB @trek

@bsclifton
Copy link
Contributor

👍

LeonB added a commit that referenced this pull request Feb 25, 2015
Allow search.json generation separate from Swiftype upload
@LeonB LeonB merged commit 8c0f4e7 into LeonB:master Feb 25, 2015
@LeonB
Copy link
Owner

LeonB commented Feb 25, 2015

Done! Thanks for the contribution. Really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants