-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow search.json generation separate from Swiftype upload #3
Conversation
That is probably its own PR, yeah? |
@Jberlinsky can you break out the testing (around Swiftype upload) into a separate PR (and remove from this)? Should help speed up acceptance of this :) |
@Jberlinsky I broke the first bit of your PR into #4 I did some testing and incorporated feedback from @trek; looking great :) Didn't mean to step on your toes, just trying to keep it simple. Awesome job BTW 👍 |
@bsclifton Thanks for the assist :) |
#4 would be ideal :) Then @Jberlinsky could merge (if you don't mind) and his PR #3 adds more testing :) |
Done. Don't mind at all. My repo is you repo :) |
Awesome; @Jberlinsky, if you were able to merge (I only had to make a few changes; for example, changing the source directory to the build directory), your PR is ready to go :) |
@bsclifton All set! cc @LeonB @trek |
👍 |
Allow search.json generation separate from Swiftype upload
Done! Thanks for the contribution. Really appreciate it. |
Inspired by emberjs/guides#2. Adds a command-line flag
--only-generate
tomiddleman swiftype
that will placesearch.json
in thesource/
directory.Also starts to add testing around Swiftype upload functionality. These are tagged with
@wip
because I couldn't seem to stub outSwiftype::Client
while executing it via the Cucumber steps.