Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing return statement #229

Merged
merged 1 commit into from
Aug 31, 2015
Merged

Fixed missing return statement #229

merged 1 commit into from
Aug 31, 2015

Conversation

fiznool
Copy link
Contributor

@fiznool fiznool commented Aug 28, 2015

For async: true, this was causing the parser to run twice - once sync, then once async.

This causes issues with calling libraries such as express-xml-bodyparser.

@fiznool fiznool mentioned this pull request Aug 28, 2015
Merged
@Leonidas-from-XIV Leonidas-from-XIV merged commit b4ccc87 into Leonidas-from-XIV:master Aug 31, 2015
@Leonidas-from-XIV
Copy link
Owner

Thanks Tom, I've merged your changes and will release a fixed version later today!

@Leonidas-from-XIV Leonidas-from-XIV self-assigned this Aug 31, 2015
@Leonidas-from-XIV
Copy link
Owner

Released as 0.4.11.

@fiznool
Copy link
Contributor Author

fiznool commented Aug 31, 2015

👍

@fiznool fiznool mentioned this pull request Sep 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Leonidas-from-XIV Leonidas-from-XIV

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiznool @Leonidas-from-XIV