Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locale-based sort #460

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fix locale-based sort #460

merged 2 commits into from
Apr 23, 2024

Conversation

LesnyRumcajs
Copy link
Owner

@LesnyRumcajs LesnyRumcajs commented Apr 22, 2024

Summary of changes
Changes introduced in this pull request:

  • fixes locale-based sort

Reference issue to close (if applicable)

Closes #458

Other information and links

https://stackoverflow.com/questions/1184268/unix-sort-treatment-of-underscore-character

Copy link
Contributor

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@@ -110,4 +110,4 @@ while read -r bench; do

EOF

done < <(find . -maxdepth 1 -type d -name '*_bench' | sort)
done < <(find . -maxdepth 1 -type d -name '*_bench' | sort --version-sort)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@LesnyRumcajs LesnyRumcajs merged commit efe2ec2 into master Apr 23, 2024
91 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-non-deterministic-sort branch April 23, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error After Re-Generating CI Workflow
2 participants