-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge level and level-browserify #50
Comments
I'm 👍 on that. Can we add level.js to the org itself? It might need some maintenance as well. |
+1 in principle and +1 on adding it to the org. But yeah, it might take some work to get it up to par with |
@vweevers Currently I'm full time on level so am willing to spend time on it! Also @juliangruber is helping out. |
After updating myself on the code, I've realized that it's actually |
I think we should release level |
+1
Make And I'd like to suggest to rewrite |
Big -1. The primary audience consists of JS users. |
@vweevers I agree that we must always make the JS users happy. However, write in TypeScript will NOT change anything to the end JS users. All JS users could still use the module by The only difference is that we write in TypeScript. And we compile the module to JavaScript before we publish it to NPM. So please don't worry about that, JS users will stay happy with JS. :) |
The audience also includes the maintainers and contributors that write this code :) Speaking for myself: I don't know TS, nor am I interested in it at the moment. I would very much like the core of the Level ecosystem to stick with JS as the primary language. This probably also goes for @ralphtheninja, @juliangruber and a whole bunch of other people here. That's not to say we can't accommodate TS users. We are more than happy to include typings and I applaud the amazing work that @MeirionHughes and yourself have done so far and will do 👌 |
@vweevers I fully understand your feelings. TypeScript did not feel good at the first look, I even feel very bad when I saw Angular(Angular2) only provide the documents with TypeScript. But after trying it a little bit, I start to know how it could make the developing job more easy and robust. Here's a great introduction video of TypeScript by Anders Hejlsberg at https://channel9.msdn.com/Events/Build/2017/B8088/, would strongly recommend taking a look. |
@zixia I think the maintainers here are die-hard js fans. I don't see the harm in starting new repositories as typescript, but think moving this entire eco-system over is a huge undertaking and will be painful to ensure nothing breaks. Right off the bat, you won't be able to do the Currently, its all prototype based too and quite well supports the older systems. If you have typescript try to "down-compile" you'll get a considerable amount of code-bloat... or a dependency to |
This would resolve problems like #34 |
+1! |
After
|
+1! |
Seeing as @ralphtheninja WDYT? |
Sure :) |
The only difference is that
level-browserify
has abrowser.js
which pulls inlevel.js
. What do you think of merging them into one, e.g. deprecatinglevel-browserify
and addinglevel.js
tolevel
?It would mean less to maintain and also simple to use
level
and it "just works".Upcoming version of
level
will bundlelevelup@2
, together withencoding-down
and have a promise layer as well, for people that prefer that.cc @Level/owners
level-browserify@2
first so we can get some testingThe text was updated successfully, but these errors were encountered: