New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract leveldown v4 #415
Conversation
Current |
Switching to |
098ea75
to
c423bbd
Compare
@vweevers Seems windows builds are passing now :) |
Will keep this PR open for a while and do amend on the latest commit as soon as |
f1d5622
to
bf81799
Compare
@vweevers Interesting. Got some weird error on AppVeyor I haven't seen before https://ci.appveyor.com/project/Level/leveldown/build/258/job/q90jmulx538af4yg |
Travis has been acting really weird the past days/week. This time it failed to download node 5 binaries with |
Travis builds for OSX seem to be borked and have been quite some time. |
@ralphtheninja do you intend to squash everything into one commit? Because I think there's enough here to warrant separate commits. |
@vweevers Yes, will squash. |
@vweevers I could make a new branch and cherry pick the stuff from this branch that are essential. |
Or rebase to remove the temporary commits, whatever works. In any case, the end result LGTM. |
Should we release this as a patch? |
Not sure. However small it may be, Level/abstract-leveldown@a2621ad is a breaking change, inherited by implementations. |
Then it should be a major. |
Just a temporary branch and a temporary PR to track build status. This PR should never be merged.Actually, why not just use this PR for updating to
abstract-leveldown@4.0.0
. It doesn't matter if this PR contains temporary commits, since we can just squash the commits when we're done.