Close dbs #167
Merged
Close dbs #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphtheninja
commented
Dec 23, 2017
| @@ -56,25 +56,28 @@ module.exports.args = function (test) { | |||
| db._put = function (key, value, opts, callback) { | |||
| t.ok(key) | |||
| t.ok(value) | |||
| callback() | |||
| process.nextTick(callback) | |||
| } | |||
| db.put({}, {}, function (err, val) { | |||
| t.error(err) | |||
| }) | |||
There was a problem hiding this comment.
No need to do the .close() dance here since .open() is never called.
vweevers
reviewed
Dec 23, 2017
| @@ -68,7 +68,6 @@ module.exports.args = function (test) { | |||
| }) | |||
|
|
|||
| test('test custom _serialize*', function (t) { | |||
| t.plan(3) | |||
There was a problem hiding this comment.
-1 on removing t.plan(3) because it asserts that db._approximateSize is indeed called.
vweevers
reviewed
Dec 23, 2017
abstract/approximate-size-test.js
Outdated
| @@ -79,6 +78,7 @@ module.exports.args = function (test) { | |||
| db.open(function () { | |||
| db.approximateSize({ foo: 'bar' }, { beep: 'boop' }, function (err) { | |||
| t.error(err) | |||
| db.close(t.end.bind(t)) | |||
There was a problem hiding this comment.
Maybe instead do:
db.close(function(err) {
t.ifError(err)
})(and update the plan count to 4)
There was a problem hiding this comment.
Ah sorry I commented on an outdated commit. You already added the close callback.
vweevers
reviewed
Dec 23, 2017
| @@ -13,7 +13,7 @@ var lastLocation = function () { | |||
| } | |||
|
|
|||
| var cleanup = function (callback) { | |||
| if (process.browser) { return callback() } | |||
| if (process.browser) { return process.nextTick(callback) } | |||
vweevers
reviewed
Dec 23, 2017
| @@ -42,16 +42,19 @@ module.exports.args = function (test) { | |||
| }) | |||
|
|
|||
| test('test custom _serialize*', function (t) { | |||
| t.plan(2) | |||
vweevers
reviewed
Dec 23, 2017
| @@ -66,7 +66,7 @@ module.exports.del = function (test) { | |||
| t.error(err) | |||
| db.del('foo', function (err) { | |||
| t.error(err) | |||
| db.get('foo', function (err) { | |||
| db.get('foo', function (err, value) { | |||
vweevers
reviewed
Dec 23, 2017
| @@ -43,16 +43,19 @@ module.exports.args = function (test) { | |||
| }) | |||
|
|
|||
| test('test custom _serialize*', function (t) { | |||
| t.plan(2) | |||
vweevers
reviewed
Dec 23, 2017
| } | ||
| db.put({}, {}, function (err, val) { | ||
| t.error(err) | ||
| }) | ||
| }) | ||
|
|
||
| test('test custom _serialize*', function (t) { | ||
| t.plan(3) |
|
|
ralphtheninja
force-pushed
the
close-dbs
branch
from
865239e
to
77fe1c7
Compare
vweevers
approved these changes
Dec 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #151
WIP Do not merge.Testing this branch in Level/leveldown#415