Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compilation on iOS #447

Merged
merged 3 commits into from
May 5, 2018
Merged

Support compilation on iOS #447

merged 3 commits into from
May 5, 2018

Conversation

axxag
Copy link
Contributor

@axxag axxag commented Apr 18, 2018

Add support for iOS compilation to enable use cases like: JaneaSystems/nodejs-mobile#64

Add IOS support
Add iOS support
Add iOS support
@vweevers
Copy link
Member

@ralphtheninja @juliangruber what's our policy on modifying vendored code (deps/)?

@juliangruber
Copy link
Member

I think if we want to merge this we should keep a patch around, ready to be applied to new versions of vendored code. Didn't we have something like this before?

@ralphtheninja
Copy link
Member

ralphtheninja commented Apr 18, 2018

@ralphtheninja @juliangruber what's our policy on modifying vendored code (deps/)?

We don't have one (at least not an explicit one). Ideally these changes should be made upstream imo and later pulled in.

I think if we want to merge this we should keep a patch around, ready to be applied to new versions of vendored code.

+1

Didn't we have something like this before?

I can't remember having something like this around. I might be wrong though. Should be visible in the CHANGELOG.

@vweevers
Copy link
Member

vweevers commented May 5, 2018

For the record, since #446, we do have a "policy" :)

Who can review this?

@ralphtheninja
Copy link
Member

Maybe we should squeeze in this as well before releasing next version.

@ralphtheninja ralphtheninja merged commit 4ce4e95 into Level:master May 5, 2018
@ralphtheninja
Copy link
Member

3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants