-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support compilation on iOS #447
Conversation
Add IOS support
Add iOS support
Add iOS support
@ralphtheninja @juliangruber what's our policy on modifying vendored code ( |
I think if we want to merge this we should keep a patch around, ready to be applied to new versions of vendored code. Didn't we have something like this before? |
We don't have one (at least not an explicit one). Ideally these changes should be made upstream imo and later pulled in.
+1
I can't remember having something like this around. I might be wrong though. Should be visible in the CHANGELOG. |
For the record, since #446, we do have a "policy" :) Who can review this? |
Maybe we should squeeze in this as well before releasing next version. |
3.0.2 |
Add support for iOS compilation to enable use cases like: JaneaSystems/nodejs-mobile#64