Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Napi rewrite #540

Merged
merged 42 commits into from
Dec 15, 2018
Merged

Napi rewrite #540

merged 42 commits into from
Dec 15, 2018

Commits on Dec 15, 2018

  1. Implement leveldown function (test/leveldown-test.js pass)

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    11797d8 View commit details
    Browse the repository at this point in the history

  2. Implement open()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    71e7823 View commit details
    Browse the repository at this point in the history

  3. Implement put() (not yet handling buffers)

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    9f03290 View commit details
    Browse the repository at this point in the history

  4. Refactor common logic from OpenWorker and PutWorker into BaseWorker

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    1fba29c View commit details
    Browse the repository at this point in the history

  5. Rename binding functions

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    e37cda0 View commit details
    Browse the repository at this point in the history

  6. Stub out iterator methods

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    085ef08 View commit details
    Browse the repository at this point in the history

  7. Lets adopt same naming as for nan case, DbContext -> Database

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    3ede7b3 View commit details
    Browse the repository at this point in the history

  8. Move leveldb specific calls to Database

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    20f2aea View commit details
    Browse the repository at this point in the history

  9. Implement iterator()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    6889722 View commit details
    Browse the repository at this point in the history

  10. Reuse LD_STRING_OR_BUFFER_TO_COPY() macro in ToSlice() function 

    The ToSlice() function corresponds to the old LD_STRING_OR_BUFFER_TO_SLICE()
macro with the exception that we _always_ copy the buffer/string. I've
chosen this approach for the following reasons:

* We use the _same_ code for copying buffers/strings for iterators (e.g.
for lt, lte, gt, gte etc)
* The code for handling cleanup of leveldb::Slice() should always cleanup
the underlying buffer (since we always copy)
* For simplicity. At the moment of rewriting to napi it's a lot to keep
in the head to move forward.

Later on we should benchmark this and tweak/optimize if needed. Maybe it
has a huge impact on performance, but until we know this for sure, I think
we can simplify with good conscience.

The difference between old LD_STRING_OR_BUFFER_TO_COPY
    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    182a58b View commit details
    Browse the repository at this point in the history

  11. Implement iterator.next() and iterator.end()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    043508a View commit details
    Browse the repository at this point in the history

  12. Implement db_close() 

    This concludes the factory-test.js in abstract-leveldown
    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    57b0be4 View commit details
    Browse the repository at this point in the history

  13. Fix error messages (needs to be copied)

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    5613fb5 View commit details
    Browse the repository at this point in the history

  14. Implement db_get()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    2acd4b6 View commit details
    Browse the repository at this point in the history

  15. Implement db_del()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    8de6618 View commit details
    Browse the repository at this point in the history

  16. Reorganize, macros at top, helpers etc

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    6f09aaf View commit details
    Browse the repository at this point in the history

  17. napi/leveldown.cc -> binding.cc

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    f7c6d93 View commit details
    Browse the repository at this point in the history

  18. Add TODO for db_close() (when open iterators)

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    64ff8f6 View commit details
    Browse the repository at this point in the history

  19. Implement batch_do() for immediate write operation

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    52ccc82 View commit details
    Browse the repository at this point in the history

  20. Implement chained batch (+ rename some functions)

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    79966af View commit details
    Browse the repository at this point in the history

  21. Implement the rest of iterator_seek() 

    This concludes the full abstract-leveldown test suite
    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    60b7982 View commit details
    Browse the repository at this point in the history

  22. Implement dc_approximate_size()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    8aba0c3 View commit details
    Browse the repository at this point in the history

  23. Fix ending open iterators while closing database (+ reorder Iterator … 

    …struct)
    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    023deae View commit details
    Browse the repository at this point in the history

  24. Fix "iterator has ended" error

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    fc46554 View commit details
    Browse the repository at this point in the history

  25. Implement db_compact_range()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    0790470 View commit details
    Browse the repository at this point in the history

  26. Implement destroy_db()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    ad079a5 View commit details
    Browse the repository at this point in the history

  27. Implement repair_db()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    a1f94da View commit details
    Browse the repository at this point in the history

  28. Implement db_get_property()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    ce049dd View commit details
    Browse the repository at this point in the history

  29. Accidentally disabled all tests but one :)

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    50062ad View commit details
    Browse the repository at this point in the history

  30. .destroy() now calls back with null

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    1dfe434 View commit details
    Browse the repository at this point in the history

  31. Reset back to normal testing

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    02cceda View commit details
    Browse the repository at this point in the history

  32. Clean up debug printf

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    cb15d6e View commit details
    Browse the repository at this point in the history

  33. Fix some napi commands + clean up old comments and reduce some if-sta… 

    …tements
    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    d6001e1 View commit details
    Browse the repository at this point in the history

  34. Dispose data pointed to by instances of leveldb::Slice

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    8855749 View commit details
    Browse the repository at this point in the history

  35. Only need to set filterPolicy once when Database object is created

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    6aca8c8 View commit details
    Browse the repository at this point in the history

  36. Use new instead of malloc to keep similar memory handling everywhere

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    cb34bf0 View commit details
    Browse the repository at this point in the history

  37. Refactor calling code into CallFunction()

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    41c19a2 View commit details
    Browse the repository at this point in the history

  38. Refactor some of the hideous iterator property code

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    4bcffea View commit details
    Browse the repository at this point in the history

  39. Compress constructor arguments a little bit

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    647c3dd View commit details
    Browse the repository at this point in the history

  40. Remove nan/v8 based glue code

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    42da176 View commit details
    Browse the repository at this point in the history

  41. Tweak back if-statements to be more clear

    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    d4dd7f0 View commit details
    Browse the repository at this point in the history

  42. Pass in leveldb::Slice into workers and not napi values 

    This is more for consistency, there were variants on this. Also makes
it more clear where the slices are created
    @ralphtheninja
    ralphtheninja committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    e80be43 View commit details
    Browse the repository at this point in the history