Remove implicit leveldown

[juliangruber]

Implicit leveldown is based on two assumptions:

• leveldown is the primary backend for levelup
• people use levelup directly (instead of convenience packages like level)

I consider both not true any more, so it's time to clean up for v2.

This pull request is based on the remove/deprecated branch, since without implicit leveldown it's impossible to expose levelup.repair and levelup.destroy.

[mcollina]

+1
Il giorno mar 26 mag 2015 alle 19:41 Julian Gruber notifications@github.com
ha scritto:

Implicit leveldown is based on two assumptions:

• leveldown is the primary backend for levelup
• people use levelup directly (instead of convenience packages like
  level)

I consider both not true any more, so it's time to clean up for v2.

This pull request is based on the remove/deprecated branch, since without
implicit leveldown it's impossible to expose levelup.repair and

levelup.destroy.

You can view, comment on, or merge this pull request online at:

#346
Commit Summary

• remove .approximateSize()
• remove .destroy() and .repair()
• remove optional leveldown
• docs

File Changes

• M README.md
  https://github.com/Level/levelup/pull/346/files#diff-0 (7)
• M lib/levelup.js
  https://github.com/Level/levelup/pull/346/files#diff-1 (55)
• M lib/util.js
  https://github.com/Level/levelup/pull/346/files#diff-2 (33)
• M package.json
  https://github.com/Level/levelup/pull/346/files#diff-3 (4)
• D test/appromixate-size-test.js
  https://github.com/Level/levelup/pull/346/files#diff-4 (92)
• M test/argument-checking-test.js
  https://github.com/Level/levelup/pull/346/files#diff-5 (31)
• M test/common.js
  https://github.com/Level/levelup/pull/346/files#diff-6 (27)
• M test/compression-test.js
  https://github.com/Level/levelup/pull/346/files#diff-7 (3)
• M test/deferred-open-test.js
  https://github.com/Level/levelup/pull/346/files#diff-8 (23)
• D test/destroy-repair-test.js
  https://github.com/Level/levelup/pull/346/files#diff-9 (81)
• M test/encoding-test.js
  https://github.com/Level/levelup/pull/346/files#diff-10 (15)
• M test/idempotent-test.js
  https://github.com/Level/levelup/pull/346/files#diff-11 (13)
• M test/init-test.js
  https://github.com/Level/levelup/pull/346/files#diff-12 (39)
• M test/inject-encoding-test.js
  https://github.com/Level/levelup/pull/346/files#diff-13 (18)
• M test/json-test.js
  https://github.com/Level/levelup/pull/346/files#diff-14 (15)
• M test/null-and-undefined-test.js
  https://github.com/Level/levelup/pull/346/files#diff-15 (15)
• M test/open-patchsafe-test.js
  https://github.com/Level/levelup/pull/346/files#diff-16 (13)
• D test/optional-leveldown-test.js
  https://github.com/Level/levelup/pull/346/files#diff-17 (73)
• M test/read-stream-test.js
  https://github.com/Level/levelup/pull/346/files#diff-18 (5)

Patch Links:

• https://github.com/Level/levelup/pull/346.patch
• https://github.com/Level/levelup/pull/346.diff

—
Reply to this email directly or view it on GitHub
#346.

[ghost]

This looks great! And we can remove all the path handling logic too that was clogging up the levelup(leveldown(...)) use-case (which should be the preferred use-case now).

[jcrugzz]

+1. Seems like this will go hand in hand with open state being handled in leveldown?

[juliangruber]

This looks great! And we can remove all the path handling logic too that was clogging up the levelup(leveldown(...)) use-case (which should be the preferred use-case now).

exactly, this is part of preparation for that. i have a julian-v2 branch https://github.com/Level/levelup/tree/julian-v2 that has that already implemented, and I'm going to try to put this into master for v2 one step at a time.

[juliangruber]

+1. Seems like this will go hand in hand with open state being handled in leveldown?

yup! abstract-leveldown already got .status here, now we just need to figure out the sane way for levelup to use it

[ralphtheninja]

Good work!