Implement destroy(), use global db store #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah yeah, tests are broken. I say we peg abstract-leveldown |
nolanlawson
force-pushed
the
destroy
branch
from
177c40c
to
b0681b3
Compare
|
rebased, mebbe it'll be green now |
| while (db.keys.length) { | ||
| delete db.store[toKey(db.keys.pop())] | ||
| } | ||
| } |
There was a problem hiding this comment.
you need to delete it out of globalStore too
There was a problem hiding this comment.
don't need to, but might as well. otherwise an empty array/object hangs around.
Also, you forgot to comment on my semicolon :P
nolanlawson
force-pushed
the
destroy
branch
from
b0681b3
to
0c60946
Compare
|
updated |
nolanlawson
force-pushed
the
destroy
branch
from
0c60946
to
9b79588
Compare
|
Missed some more semicolons. When in Rome... |
|
NO SEMICOLONS WE ARE IN ROME AND THEY SHOOT SEMICOLONS IN ROME |
| function getOrCreateDatabaseFromGlobal(name) { | ||
| var key = toKey(name) | ||
| , db = globalStore[key] | ||
| if (!db) { |
There was a problem hiding this comment.
also it doesn't need braces since it's trivial
|
fine by me with minor style tweaks |
|
sorry for the delay. de-Crockfordized the code and ready to push now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22.
There's now a global store that keeps track of all memdown databases, keyed by location. so if you do:
then both
db1anddb2will contain the same data.I also added a destroy test here, rather than in abstract-leveldown, because memdown isn't even passing the latest abstract-leveldown tests. If you want to see these tests pass at 100%, we're going to need to peg abstract-leveldown to v0.12.3 due to the snapshot test.