peg abstract-leveldown to skip snapshot test #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So basically this would be a replacement for #21 where we just give up and peg to an old version of abstract-leveldown, until we can skip the test e.g. as I did in No9/localstorage-down#58 |
|
👍 for a short term solution |
nolanlawson
force-pushed
the
peg-abstract-leveldown
branch
from
587f586
to
8e346d0
Compare
nolanlawson
changed the title
|
sorry for typo, waiting for green. thanks for the vote of confidence :) |
|
its green merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of #23 and #21 I would really rather we just peg abstract-leveldown to a working version and then work form there.