Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #17 and #18.
There seemed to be a few ways to go about updating this to work with Node.js v10.
I went through the process of updating
level
. This required wrappingmultileveldown
inencoding-down
and cause some of the tests to fail with encoding issues. For instance, a test would want42
, but would get'42'
or theBuffer
for42
, but not the actual int.An easier path seemed to keep
level
at v1.x, which handles encodings, and have it use v2 ofleveldown.
This is what my fork does.I then updated this to use that new fork, resulting in a successful install on Node.js v10.