Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js v10 support #19

Closed
wants to merge 7 commits into from
Closed

Conversation

MattMorgis
Copy link

Should close #17 and #18.

There seemed to be a few ways to go about updating this to work with Node.js v10.

I went through the process of updating level. This required wrapping multileveldown in encoding-down and cause some of the tests to fail with encoding issues. For instance, a test would want 42, but would get '42' or the Buffer for 42, but not the actual int.

An easier path seemed to keep level at v1.x, which handles encodings, and have it use v2 of leveldown. This is what my fork does.

I then updated this to use that new fork, resulting in a successful install on Node.js v10.

@achingbrain
Copy link

Hopefully this will get merged but you might be better off renaming your fork & publishing it as a new module.

@vweevers
Copy link
Member

vweevers commented Dec 8, 2019

Superseded by #20.

@vweevers vweevers closed this Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 10
3 participants