Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include prebuilt binary for alpine #174

Closed
gogoout opened this issue Jul 15, 2021 · 5 comments
Closed

Include prebuilt binary for alpine #174

gogoout opened this issue Jul 15, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@gogoout
Copy link

gogoout commented Jul 15, 2021

Hi all, Alpine is commonly used in container environment.
Currently seems alpine seems doesn't have a prebuilt binary. Not sure if this is a low hanging fruit.

@vweevers vweevers added the enhancement New feature or request label Jul 15, 2021
@vweevers
Copy link
Member

Assuming that RocksDB compiles against musl (no reason to believe it doesn't), this should be easy. We do the same for leveldown. It's a matter of adding -i alpine to:

"prebuild-linux": "prebuildify-cross -i centos7-devtoolset7 -t 8.14.0 --napi --strip",

If no one is opposed to increasing npm package size. I'm fine with that.

@vweevers vweevers added this to To Do in Level (old board) Jul 31, 2021
@vweevers vweevers moved this from To Do to In progress in Level (old board) Aug 1, 2021
vweevers added a commit that referenced this issue Aug 1, 2021
@reuzel
Copy link

reuzel commented Aug 7, 2021

Great work!

Is there any ETA for the next release in which this binary will be prepackaged?

@vweevers
Copy link
Member

vweevers commented Aug 7, 2021

When I have a free moment, within a week.

@gogoout
Copy link
Author

gogoout commented Aug 21, 2021

Hi, any updates on releasing?

@vweevers
Copy link
Member

5.1.0

Level (old board) automation moved this from In progress to Done Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

3 participants