Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zALLMATCHSCAN #5

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

McPatate
Copy link
Collaborator

@McPatate McPatate commented Jan 17, 2023

  • Add zALLMATCHSCAN command.
  • Refactored the decoder as ClamAV can output multiple \0 terminated lines.
  • Also added a check that clamd is running on cargo test to improve dev exp.

Note that I will rebase #4 once it's merged so that this PR contains only the last commit 740e442

@McPatate
Copy link
Collaborator Author

I've realised that there must be some issue in the parsing of the stream. After a few commands when .keep_alive(true), the client goes into error. Looking into it

@McPatate
Copy link
Collaborator Author

Very strange, tests pass on my machine. Could you check if tests also work for you @LevitatingOrange ?

@LevitatingOrange
Copy link
Owner

Very strange, tests pass on my machine. Could you check if tests also work for you @LevitatingOrange ?

Yeah weird, they pass on my machine too.

@McPatate
Copy link
Collaborator Author

McPatate commented Jul 18, 2023

@LevitatingOrange do you have some time to review ? It works nicely in production.

I was wondering, do we want to deduplicate when ClamAV reports the same signature multiple times?

EDIT: regarding ^, now that I think of it, it may be useless/annoying to do once we switch to Vec<ScanResult>. If it were only strings, we could easily just do HashSet<String>, but with ScanResults I wonder if this makes sense. We should let the user do his own thing if he wants to dedup signatures, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants