Skip to content

Commit

Permalink
acme/autocert: skip renewal tests broken on windows/arm64
Browse files Browse the repository at this point in the history
For golang/go#51080

Change-Id: Icf4414ab58bdea44b793a66770b4c05f9faf5387
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/385675
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
  • Loading branch information
Bryan C. Mills committed Feb 14, 2022
1 parent 6992913 commit 6943e79
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions acme/autocert/renewal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"context"
"crypto"
"crypto/ecdsa"
"runtime"
"testing"
"time"

Expand Down Expand Up @@ -42,6 +43,15 @@ func TestRenewalNext(t *testing.T) {
}

func TestRenewFromCache(t *testing.T) {
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
// This test was observed to fail frequently in Dial with "connectex: No
// connection could be made because the target machine actively refused it."
//
// Failures started around CL 381715, so it looks to me (bcmills) like an
// undiagnosed bug in (or exposed by) acmetest.CAServer.
t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
}

man := testManager(t)
man.RenewBefore = 24 * time.Hour

Expand Down Expand Up @@ -127,6 +137,15 @@ func TestRenewFromCache(t *testing.T) {
}

func TestRenewFromCacheAlreadyRenewed(t *testing.T) {
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
// This test was observed to fail frequently in Dial with "connectex: No
// connection could be made because the target machine actively refused it."
//
// Failures started around CL 381715, so it looks to me (bcmills) like an
// undiagnosed bug in (or exposed by) acmetest.CAServer.
t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
}

ca := acmetest.NewCAServer(t).Start()
man := testManager(t)
man.RenewBefore = 24 * time.Hour
Expand Down

0 comments on commit 6943e79

Please sign in to comment.