New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespaces #393
Merged
Merged
Namespaces #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namespace
Moved a file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my long-term goals was to bring this repo up to MODERN PHP Standards (we Predate PHP 7, let alone 8!) and make it easier to update.
I used LWTV as my testbed to build out an autoloader, and restructured things as follows:
functions.php
- Main Plugin file. Loads auto-loader, components, and defines./assets/
- Plugin assets/bin/
- Scripts used for PHP Unit Testing/node_scripts/
- Scripts used by Node to properly move content./php/
- All functional code/plugins/
- Forked 3rd party plugins/tests/
- Unit TestsInstead of 100 top-level folders, all the code is in
/php/
and uses the concept of implementing components that can be dynamically called.The code is about 80% documented via DocBlocks, and the readme are up to date.
Components
A Component can be thought of as a sub-plugin. It is an atomic, independent module that stores business logic related to a specific feature. It may expose some template tags (functions) that can be called from within the theme as
lwtv_plugin()->FUNCTION_NAME()
which allows us to connect plugin and theme without needing to know specific classes and/or namespaces.All Components are stored in
/php/
and the details of their use and implementation is in/php/readme.md
To Do
Post Merge
After this is merged, you must run LezWatch/lwtv-underscores#199 to ensure the theme is compatible